ci: use sdk version files#2392
Merged
Merged
Conversation
This was referenced Jun 23, 2026
wpessers
reviewed
Jun 27, 2026
wpessers
left a comment
wpessers
left a comment
Member
There was a problem hiding this comment.
@thompson-tomo I think your idea here is good. Just thinking we probably want to move to something like mise in the future to make DX better than it is.For now I think we can go through with this though.
wpessers
requested changes
Jun 27, 2026
Member
|
@thompson-tomo one nit, other than that LGTM. |
Co-authored-by: Warre Pessers <45464718+wpessers@users.noreply.github.com>
Contributor
Author
|
No worries @wpessers have committed that suggestion. |
wpessers
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the ci tasks to source versions from sdk files.
This decouples the sdk updates from the github action updates & enables a consistent version to be used locally.
Note renovate will still detect the dependencies & offer updates to them.